This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Refactoring using proper react-router practices #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bit of refactoring:
When I originally set up the routing, I was unaware of the proper method for nested routes in react-router. Having figured them out recently, I figure it would be a good time to correct my mistakes here. Basically, the root route serves an
App
component, which includes the header and side menu I want on all child routes. Thethis.props.children
line inApp
renders whatever child route component visited (Secrets
,Settings
etc.)Not sure why I implemented a polling mechanism for checking logout when I'm given the exact time. I've replaced the
setInterval
calls with asetTimeout
incomponentDidMount
which warns exactly two minutes prior to expiration and anothersetTimeout
to boot the user back to the login page. I do not bother to clear the timeout on unmount, because the only time the App component will unmount is when logout occurs.