This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Adding token and username/password as login options #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucretius
commented
Nov 8, 2016
| } | ||
| }) | ||
| .then((resp) => { | ||
| //DJ fill in the blanks here |
There was a problem hiding this comment.
DJ you'll need to handle this part - and on the server as well. Right now, anything besides the Github auth method throws a 400 bad request error server side.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added username/password as well as auth token support. The default is Github, but you can change things in a dropdown which will appear in the settings menu.
I've also gone ahead and added error handling to the server, so that bad requests notify the client of the error.