Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

fix invalid github endpoint var name #155

Merged
merged 4 commits into from
Jul 27, 2017
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:7-alpine
FROM node:8.1.4-alpine

MAINTAINER Vault-UI Contributors

Expand All @@ -7,7 +7,9 @@ COPY . .

RUN yarn install --pure-lockfile --silent && \
yarn run build-web && \
npm prune --silent --production && \
yarn install --silent --production && \
yarn check --verify-tree --production && \
yarn global add nodemon && \
yarn cache clean && \
rm -f /root/.electron/*

Expand Down
4 changes: 2 additions & 2 deletions app/components/Authentication/Github/Github.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ export default class GithubAuthBackend extends React.Component {
floatingLabelText='GitHub endpoint'
fullWidth={true}
floatingLabelFixed={true}
value={this.state.newConfig.endpoint}
value={this.state.newConfig.base_url}
onChange={(e) => {
this.setState({ newConfig: update(this.state.newConfig, { endpoint: { $set: e.target.value } }) });
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but it looks like you missed this one. This line should read:

this.setState({ newConfig: update(this.state.newConfig, { base_url: { $set: e.target.value } }) });

}}
Expand Down Expand Up @@ -564,4 +564,4 @@ export default class GithubAuthBackend extends React.Component {
</div >
);
}
}
}