This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried this out and works flawlessly. |
djenriquez
approved these changes
Apr 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @msessa, very concise and simple.
@msessa Actually I did find one quirk with this. The filtering is case sensitive. So, |
Nice catch @Naf. Should be an easy change I can get to later today, missing a toLowerCase() somewhere, unless someone beats me to it.
DJ Enriquez
… On Apr 28, 2017, at 6:56 AM, NAF ***@***.***> wrote:
@msessa Actually I did find one quirk with this. The filtering is case sensitive. So, H vs hwill mean you will miss results.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Would be great if that was also available for the "Tokens Auth Endpoint"!!! |
is this filter not working in latest code? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
Implemented in: