This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Remove trailing slashes in vault address before sending request #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djenriquez
approved these changes
Apr 26, 2017
|
Let's release a hotfix, 2.1.1, for this. |
|
Sure, but before you do give me a couple of hours to look into that UI bug where the icon for a RaisedButton doesn't correctly show. I'd like to get that one into the hotfix release too Ex:
|
|
Of course man, no rush. Such is the beauty of an open-source project =P. |
|
@msessa going to merge this in for 2.2.0, feel free to open up a new PR for the weird UI bug you mentioned above. |
|
Nah that was a glitch on my dev station probably because of some stale cache. all good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103.
I opted for a one-liner fix to the specific issue instead of including a whole new dependency to handle URL joining.