This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Hook into vault #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucretius
reviewed
Nov 6, 2016
| next(); | ||
| }); | ||
|
|
||
| app.listen(PORT, () => { |
There was a problem hiding this comment.
I usually throw this line on the very bottom after I register all of my routes.
Lucretius
reviewed
Nov 6, 2016
| @@ -0,0 +1,29 @@ | |||
| import express from 'express'; | |||
| import bodyParser from 'body-parser'; | |||
| import favicon from 'serve-favicon'; | |||
There was a problem hiding this comment.
probably dont need this favicon thing.
Lucretius
reviewed
Nov 6, 2016
| "lodash": "^4.16.6", | ||
| "material-ui": "^0.16.1", | ||
| "react": "^15.3.2", | ||
| "react-dom": "^15.3.2", | ||
| "react-router": "^3.0.0", | ||
| "react-tap-event-plugin": "^1.0.0" | ||
| "react-tap-event-plugin": "^1.0.0", | ||
| "serve-favicon": "^2.3.0" |
There was a problem hiding this comment.
same here about the favicon
added 2 commits
November 7, 2016 17:25
- Using express backend server to make calls to the Vault API to bypass CORs - Adding login, list secrets, and get secrets calls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.