Fix effects getting stuck after a deletion #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some effects not updating after one or more effects have been deleted. This was due to the indirect pass shader assuming a contiguous `ParticleGroup` array, but that array contains gaps where effects have been deallocated, so updating a number of rows equal to the number of active effect means updating some unused rows and skipping some used ones in case there's any gap.
djeedai
added
C - bug
|
@NiseVoid if you want to try that change, it should fix effects getting stuck after another effect was deleted. |
djeedai
added a commit
that referenced
this pull request
Oct 17, 2024
Invalidate the sim bind group when the particle buffer is re-allocated. Also always re-create that bind group for now, as we don't invalidate on binding offset/size changes. With that, revert the fix for #330, which shouldn't be needed because the buffer is indeed contiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some effects not updating after one or more effects have been deleted. This was due to the indirect pass shader assuming a contiguous
ParticleGrouparray, but that array contains gaps where effects have been deallocated, so updating a number of rows equal to the number of active effect means updating some unused rows and skipping some used ones in case there's any gap.