Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases for delete methods #307

Merged
merged 5 commits into from
Dec 1, 2024

Conversation

Elsie-ND
Copy link
Contributor

@djeck1432 kindly review changes made to the issue: #268

@djeck1432 djeck1432 self-requested a review November 29, 2024 20:37
@djeck1432 djeck1432 linked an issue Nov 29, 2024 that may be closed by this pull request
@djeck1432
Copy link
Owner

@Elsie-ND Pipeline is failed, please fix that

Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you create new files instead of insert those test cases to existing ones?

@djeck1432
Copy link
Owner

@Elsie-ND you will be unassigned if there is no update during next few hours

@Elsie-ND
Copy link
Contributor Author

Elsie-ND commented Nov 30, 2024

@djeck1432 please I am moving the tests to the existing files and I will be done by today

@djeck1432
Copy link
Owner

@Elsie-ND it takes 5 mins, do you need for that 5 hours?
tomorrow morning you will be unassigned

@djeck1432
Copy link
Owner

Screenshot 2024-12-01 at 12 32 15 @Elsie-ND PLease, check it after pushing your changes, fix it

@djeck1432
Copy link
Owner

@Elsie-ND Please, sync with main branch

@djeck1432
Copy link
Owner

@Elsie-ND Please, fix changes, last PR

@djeck1432
Copy link
Owner

@Elsie-ND You will be unassigned, as far as all testes are broken and you didn't response/pushed any commits during 24 hours. you have a few more hours

@djeck1432 djeck1432 merged commit 9de4e20 into djeck1432:main Dec 1, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Create test cases for new crud methods
2 participants