Replace async_trait with native async fns #230
Conversation
|
@djc we have an issue with the coverage pipeline: |
bb8/src/api.rs
Outdated
| @@ -406,8 +408,12 @@ pub trait CustomizeConnection<C: Send + 'static, E: 'static>: | |||
| /// | |||
| /// The default implementation simply returns `Ok(())`. If this method returns an | |||
| /// error, it will be forwarded to the configured error sink. | |||
| async fn on_acquire(&self, _connection: &mut C) -> Result<(), E> { | |||
| Ok(()) | |||
| fn on_acquire<'a, 'b, 'r>(&'a self, _connection: &'b mut C) -> BoxFuture<'r, Result<(), E>> | |||
There was a problem hiding this comment.
Can we spell this <'r, 'a: 'r, 'b: 'r> instead? And do we really need the 3 separate lifetimes?
Why is BoxFuture useful? Could we just do Box<dyn Future<..>> instead?
There was a problem hiding this comment.
BoxFuture<'a, T> is actually Pin<Box<dyn Future<Output = T> + Send + 'a>>. I'll apply the suggestions.
There was a problem hiding this comment.
And do we really need the 3 separate lifetimes?
I'm not sure, but that's what async_trait generated, so I kept it to prevent further breaking changes in the API.
|
I think #231 has solved the coverage issue, please rebase on top of current main. |
gahag-cw
force-pushed
the
feat/remove-async-trait
branch
from
e88d79c to
7343297
Compare
|
@djc I applied the following suggested changes:
Let me know if you have any further suggestions. |
gahag-cw
force-pushed
the
feat/remove-async-trait
branch
from
7343297 to
148d27a
Compare
|
Please also add a separate commit that bumps all the version numbers. |
gahag-cw
force-pushed
the
feat/remove-async-trait
branch
from
148d27a to
dce257b
Compare
gahag-cw
force-pushed
the
feat/remove-async-trait
branch
from
dce257b to
8c104dd
Compare
|
@djc done. |
|
Thanks! |
|
Note that the usage of
CustomizeConnectionrequires it to be object safe, and thus we need to use boxed futures instead of plain async fns.