-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template node structs & whitespace semantics #829
Open
couchand
wants to merge
27
commits into
djc:main
Choose a base branch
from
couchand:2023-06/ws-semantics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ec8301d
Add test for parsing Node::Call
couchand fcb01b6
Extract Call struct from Node
couchand 586c770
Extract Match struct from Node
couchand a31b7ad
Make When a proper struct
couchand b586040
Make Cond a proper struct
couchand 27a2075
Extract Lit struct from Node
couchand 0b6bbca
Push name into Macro struct
couchand ccc6f50
Add test for Macro parse
couchand 00c4e93
Clarify Macro Ws semantics
couchand 92bf3b8
Add test for parsing raw blocks
couchand cfcf8c8
Extract Raw struct from Node and clarify inner/outer Ws
couchand eb71bdc
Add test for BlockDef parse
couchand 21bf9a5
Extract BlockDef struct from Node and clarify inner/outer Ws
couchand 8dd962a
Add test for parsing Node::Loop
couchand 3ea5da8
Clarify Loop outer/body/else Ws
couchand d551120
Add test for parsing Node::Match Ws
couchand 4140503
Clarify Match arms/outer Ws semantics
couchand 15cbcd8
Add test for parsing Node::Cond
couchand 265702f
Clarify Cond branch/outer Ws semantics
couchand 9469675
Inline write_comment in Generator::handle
couchand 2657abd
Handle Expr Ws in Generator::handle
couchand ad83909
Handle LetDecl Ws in Generator::handle
couchand 0b02a31
Handle Let Ws in Generator::handle
couchand 64fbc47
Move Node::Include Ws handling to caller
couchand 15c4e82
Inline handle_ws in Generator::handle
couchand 3a37e8c
Don't destructure Call in Generator::handle
couchand 981fb6b
Don't destructure Match in Generator::handle
couchand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to do this, I think we should just pass the
&Call
directly towrite_call()
... Not much point in destructing it here. (Same for other node types.)