Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derive for impl From<{Template}> for hyper::Body #776

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

valkum
Copy link
Contributor

@valkum valkum commented Feb 10, 2023

The with-hyper feature will now, when enabled, generate a From implementation allowing Templates to be passed to functions with trait bounds for Into<hyper::Body>.

Copy link
Owner

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Maybe change the PR to target the 0.11.x branch? Then we can push it out faster.

askama_derive/src/generator.rs Show resolved Hide resolved
with-hyper now derives an impl allowing Templates to be passed
to functions with trait bounds for Into<hyper::Body>.
@valkum valkum force-pushed the hyper_derive_into_hyper_body branch from a81bd1c to 0762d8c Compare February 10, 2023 12:56
@valkum valkum changed the base branch from main to 0.11.x February 10, 2023 13:16
@valkum valkum changed the base branch from 0.11.x to main February 10, 2023 14:15
@djc djc merged commit 32f0799 into djc:main Feb 13, 2023
@djc djc mentioned this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants