Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't parse non-template attributes #549

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Don't parse non-template attributes #549

merged 1 commit into from
Nov 10, 2021

Conversation

djc
Copy link
Owner

@djc djc commented Oct 13, 2021

Fixes #543.

@djc
Copy link
Owner Author

djc commented Oct 13, 2021

(Windows CI seems flaky today.)

vallentin
vallentin previously approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@vallentin vallentin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ran the checks and they all passed. So yeah, seems Windows CI is being weird today.

Could be simplified with map_err, however either way is fine with me, so I'm approving.

askama_shared/src/input.rs Outdated Show resolved Hide resolved
@djc
Copy link
Owner Author

djc commented Nov 10, 2021

@vallentin would you mind approving this again?

@djc djc merged commit f06022c into main Nov 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the skip-non-template-attrs branch November 10, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vallentin vallentin vallentin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-meta attributes (e.g. #[bad(x = foo::bar)]) cause parsing to fail unnecessarily
2 participants
@djc @vallentin