Fixed parsing precedence and associativity #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #381
This pull request fixes the parser, such that it produces a correct AST in relation to precedence and associativity.
As mentioned in the issue, given that Askama emits the expressions unmodified, then in that regard there isn't any noticeable change. However, with a correct AST it prevents any potential future problems.
In short
a + b == c
was previously parsed as(a + (b == c))
and now is correctly parsed as((a + b) == c)
.I also added a few test cases to check that the parser upholds precedence and associativity. (If you want the test cases split into multiple functions, then mention it and I'll split them.)
This does not introduce any breaking changes.