Change askama_escape to require UTF-8 strings #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for working on this! In order to make this easier to review, could you please split this in commits where your changes to make the interface safe are not intermixed with unrelated renaming/other refactoring? |
|
Sorry, I don't know what "unrelated renaming" you're referring to — as far as I can tell, all of the renaming is just getting rid of the word |
|
Sorry this has taken me so long, it's been super-busy. But this looks basically solid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make
askama_escapesafe, but it changes some parts of the interface, which aren't used by Askama.Fixes #242.