Feature Update: Counters Added WhatIsDjango Section #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saurabhsharma884
requested changes
Sep 20, 2024
Co-authored-by: Saurabh Sharma <[email protected]>
|
Done
… On 20 Sep 2024, at 10:16, Saurabh Sharma ***@***.***> wrote:
@Saurabhsharma884 commented on this pull request.
In frontend/src/sections/WhatIsDjango/WhatIsDjango.tsx <#149 (comment)>:
> @@ -3,6 +3,7 @@
import Image from 'next/image'
import { Button } from ***@***.***'
import useWidth from '@/hooks/useWidth'
+import DataCard from '@/components/DataCard/datacard'
Change the line function DataCard() { to export const DataCard = () => {
Remove the line export default DataCard from end of file.
create index.ts in components/DataCard and add export * from './datacard'
add export * from './DataCard' in components/index.ts
try importing DataCard in same line as Button
—
Reply to this email directly, view it on GitHub <#149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKG4K7ZRG3BJKR24UJ6J66LZXOSCLAVCNFSM6AAAAABOQW6V72VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJXGI2TKNRSGM>.
You are receiving this because you authored the thread.
|
|
Merged without a single approval? |
|
Merged into my own PR branch, not main. Change target branch suggestion meant that, or no ?- ZPOn 21 Sep 2024, at 10:05, Bhuvnesh ***@***.***> wrote:
Merged without a single approval?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes
I have a plan behind it for the community, kindly make live for the event.