Fixed #34744 -- Prevented recreation of migration for constraints with a dict_keys. #17114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxiao
force-pushed
the
ticket_34744
branch
2 times, most recently
from
fe8c78b to
ef592a9
Compare
felixxm
reviewed
Aug 7, 2023
|
@shangxiao Do you have time to keep working on this? |
|
@felixxm Oops I missed the review from 2 weeks ago ❤️ Your approach sounds more reasonable. Looks like you'd already written up the patch and tested it? If you like I can work with what you posted though? 🤷♂️ |
Thanks, that would be appreciated. |
shangxiao
force-pushed
the
ticket_34744
branch
from
ef592a9 to
7db96c9
Compare
felixxm
changed the title
felixxm
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
@shangxiao Thanks 👍 I moved tests to the tests/migrations/test_autodetector.py.
…h a dict_keys. Co-authored-by: Mariusz Felisiak <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for Ticket 34744 - Migration re-add constraints when check condition contains a dict_keys object.
I'm not super-familiar with how migration serialisation works. I had a look to see if there was a way to serialise an entire project state but couldn't see anything 🤔 If you can do this then it's probably better to serialise the state before passing to the Autodetector.
This alternative is to serialise constraints before checking their equality. This solution is too narrow though - perhaps this problem could appear again in other parts of the state? 🤷♂️
Maybe we should try to serialise everything manually.