Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy DEP 14 a bit #90

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Tidy DEP 14 a bit #90

merged 1 commit into from
Jun 6, 2024

Conversation

adamchainz
Copy link
Member

@adamchainz adamchainz commented Jun 1, 2024 •
edited
Loading

  1. Indent Python code with four spaces, rather than three.
  2. Modernize and complete the type hints, specifically replacing Dict and List with dict[k, v] and list (or tuple[Any, ...] in the case of Task.args).
  3. Tidy language around asynchronous tasks, including expanding the “async” shorthand and removing its syntax highlighting.
  4. Replace the term “globally-importable” with “module-level”, which is what I understood was meant.
  5. Use the term “enqueueing” consistently.

@adamchainz
Copy link
Member Author

@RealOrangeOne

RealOrangeOne
RealOrangeOne approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have absolutely no idea how the indenting got this messed up, but thanks for cleaning it up!

I also the changed wording is much clearer - thanks again.

@RealOrangeOne
Copy link
Contributor

As you're already here, it'd be great if you could amend #86 (comment) at the same time! 🙂

@adamchainz @PeterJCLaw
Tidy DEP 14 a bit
e7efa62 
co-authored-by: Peter Law <[email protected]>
@adamchainz
Copy link
Member Author

As you're already here, it'd be great if you could amend #86 (comment) at the same time! 🙂

Done, merging!

@adamchainz adamchainz merged commit 5e97684 into main Jun 6, 2024
@adamchainz adamchainz deleted the tidy_dep_14 branch June 6, 2024 07:02
@adamchainz adamchainz mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealOrangeOne RealOrangeOne RealOrangeOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamchainz @RealOrangeOne