Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 'Last Modified' field #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop 'Last Modified' field #64

wants to merge 1 commit into from

Conversation

adamchainz
Copy link
Member

Following discussion in #62, realized this field is out of sync, we can retrieve the information from Git, and several DEP's never had the field.

Copy link

@manfre manfre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the :Last-Modified: to reflect when the content/substance of the DEP has last changed, instead of the last time anything in the file was changed? If the latter, then we should definitely remove them.

@adamchainz
Copy link
Member Author

Even if it's the former, I believe it's out of sync for most of them.

Base automatically changed from master to main February 25, 2021 16:04
@adamchainz
Copy link
Member Author

@felixxm thoughts?

@RealOrangeOne
Copy link
Contributor

Speaking from my experiences on #86, I often forget to update the Last-Modified field. Sure, it's useful as a marker for "when did this content notably change", but you can get the majority of that from commit history.

Big +1 👍 from me on this!

@carltongibson
Copy link
Member

+1.

@hvdklauw
Copy link

Isn't this whole PR a reason to keep the field? If this goes through then all the files histories get an extra commit to change the structure of the files thus polluting the git history with irrelevant history for the specific DEP.

Before you know it you end up going through a long history just to find the last actual change relevant to the subject matter in the DEP.

I think you should keep the meta-data in the file or adopt a standard to differentiate between content commits and structure commits, so it's easier to see the difference.

But that's just my 2 cents.

Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! I don’t see how this field helps in any way considering if you really need that kind of date you’re better off looking at commits or pull request comments.

Note this PR would be even better if it also removed the field from the template file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants