implement a TTL for RedisChannelLayer.receive_buffer (to avoid a memory leak) #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
commented
Jul 27, 2020
| @@ -616,6 +651,7 @@ async def group_discard(self, group, channel): | |||
| key = self._group_key(group) | |||
| async with self.connection(self.consistent_hash(group)) as connection: | |||
| await connection.zrem(key, channel) | |||
| self.receive_buffer.expire() | |||
There was a problem hiding this comment.
Maybe we can't rely on this only happening on group_discard (since some may not be using the group extension?).
Doing this sort of thing once per receive() call seems too expensive, though.
ryanpetrello
force-pushed
the
recv_buffer_leak
branch
7 times, most recently
from
2e8097f to
dd894ad
Compare
|
Using https://github.com/ryanpetrello/channels-redis-leak as a reproducer, I've applied this patch. Here's a bunch of references to messages:
...here's what happens if I wait 60+ seconds and disconnect/reconnect w/ a new websocket client:
|
ryanpetrello
changed the title
ryanpetrello
force-pushed
the
recv_buffer_leak
branch
from
dd894ad to
3f66c3c
Compare
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Jul 31, 2020
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Jul 31, 2020
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Jul 31, 2020
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Aug 3, 2020
|
On further testing, this seems like it also slowly leaks 😞 |
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Aug 11, 2020
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #212
cc @carltongibson @agronick