Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require asgiref version equal or higher than 3.5.0 #1794

Merged

Conversation

pdonorio
Copy link
Contributor

Given the issue found in #1713,
updating related requirements,
to help users who already have the library installed to not face the same problems.

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, OK, come on then. Let's have this. Thanks.

@carltongibson
Copy link
Member

Ah, yes, time to drop PY36.

@pdonorio
Copy link
Contributor Author

Ah, yes, time to drop PY36.

Most likely to be a separated PR?

Do you need me to do it, or are you able to?
Thanks for any support.

@carltongibson
Copy link
Member

Yes, separate PR — I'm very happy if you'd like to help with that!

@smithdc1
Copy link
Member

See #1787 for dropping Python 3.6 (and unsupported Django versions).

Given the issue found in django#1713, updating related requirements, to help
users who already have the library installed to not face the same
problems.
@pdonorio pdonorio force-pushed the paolo/update-requirements-over-asgiref branch from 76fe701 to 2cc3107 Compare January 28, 2022 09:49
@pdonorio
Copy link
Contributor Author

Thanks @smithdc1 !

I've just rebased on the updated main.

@smithdc1
Copy link
Member

smithdc1 commented Feb 3, 2022

Thanks for rebasing this. I don't have write access to this repo so we will need @carltongibson to merge.

@carltongibson carltongibson merged commit 08c9315 into django:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants