SSR functionality #258
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| import { file, group, match } from 'webpack-blocks' | ||
|
|
||
| export default function assets(config = {}) { | ||
| return group([ | ||
| // will copy font files to build directory and link to them | ||
| match(['*.eot', '*.ttf', '*.woff', '*.woff2', '*.png', '*.jpg', '*.svg'], [ | ||
| file({ emitFile: !config.ssr }), | ||
| ]), | ||
| ]) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import { group, devServer as devServerBlock } from 'webpack-blocks' | ||
| import path from 'path' | ||
| import get from 'lodash/get' | ||
| import { getFilenameFromUrl } from 'webpack-dev-middleware/lib/util' | ||
| import { match as proxyMatch } from 'http-proxy-middleware/lib/context-matcher' | ||
| import getContent from '../src/ssr/get-content' | ||
| import decache from 'decache' | ||
|
|
||
|
|
||
| const publicPath = path.resolve(`${process.env.OUTPUT_PATH}`) | ||
|
|
||
| export default function devServer() { | ||
| return devServerBlock({ | ||
| contentBase: path.resolve(`${process.env.OUTPUT_PATH}`), | ||
| port: process.env.DEV_SERVER_PORT || 3000, | ||
| overlay: true, | ||
| clientLogLevel: 'info', // FIXME move to VERBOSE mode (add loglevel/verbose option) | ||
| stats: 'minimal', | ||
| host: process.env.DEV_SERVER_HOST, | ||
|
|
||
| // FIXME | ||
| filename: 'bundle.js', | ||
|
|
||
| allowedHosts: [ | ||
| '.localhost', | ||
| `.${process.env.MAIN_HOST}`, | ||
| ], | ||
|
|
||
| writeToDisk: true, | ||
|
|
||
| before: middleware, | ||
| }) | ||
| } | ||
|
|
||
| function middleware(app, server, compiler) { | ||
| app.get('*', function(req, res, next) { | ||
| if(!process.env.SSR) { | ||
| return next() | ||
| } | ||
|
|
||
| let accept = String(get(req, 'headers.accept', '')) | ||
|
There was a problem hiding this comment. where do you use this variable? |
||
|
|
||
| let isWebpackAsset = getFilenameFromUrl( | ||
|
|
||
| process.env.PUBLIC_PATH, | ||
| compiler, | ||
| req.url | ||
| ) | ||
|
|
||
| let isProxyMatched = proxyMatch( | ||
|
|
||
| JSON.parse(process.env.PROXY), | ||
| req.originalUrl || req.url, | ||
| req | ||
| ) | ||
|
|
||
| // skip | ||
| if(isWebpackAsset || isProxyMatched) { | ||
| return next() | ||
| } | ||
|
|
||
| // run SSR | ||
| // TODO ensure that compilation is completed | ||
| decache('../dist/ssr/ssr') | ||
| return getContent(req.url) | ||
| .then(c => res.send(c.content)) | ||
| .catch(e => { | ||
| res.status(500).send('Internal server error.') | ||
| console.error(e) | ||
| }) | ||
| }) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { group, match, devServer, env, addPlugins } from 'webpack-blocks' | ||
| import path from 'path' | ||
| import webpack from 'webpack' | ||
|
|
||
| export default function ssr(config) { | ||
|
|
||
| return group([ | ||
| match(['*.css', '*.sass', '*.scss', '*polyfills.js'], [ | ||
| nothing(), | ||
| ]), | ||
|
|
||
| /* | ||
| env('development', [ | ||
| devServer({ | ||
| inline: false, | ||
| // FIXME hot updates still created | ||
| hot: false, | ||
| }) | ||
| ]), | ||
| */ | ||
| ]) | ||
| } | ||
|
|
||
| function nothing(options = {}) { | ||
| return (context, util) => | ||
| util.addLoader( | ||
| Object.assign( | ||
| { | ||
| use: 'null-loader', | ||
| }, | ||
| context.match | ||
| ) | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,48 @@ | ||
| import { Fragment } from 'react' | ||
| import { Provider } from 'react-redux' | ||
| import { Router } from 'common/router' | ||
| import { CheckCache } from '@ds-frontend/cache' | ||
| import routes from './routes' | ||
| import PropTypes from 'prop-types' | ||
|
|
||
| App.propTypes = { | ||
| store: PropTypes.object.isRequired, | ||
| routerContext: PropTypes.object, | ||
| origin: PropTypes.string, | ||
| staticUrl: PropTypes.string, | ||
| } | ||
|
|
||
| App.defaultProps = { | ||
| routerContext: {}, | ||
| origin: undefined, | ||
| staticUrl: undefined, | ||
| } | ||
|
|
||
|
|
||
| function App({ store, staticUrl, origin, routerContext }) { | ||
| try { | ||
| const CheckCacheComponent = process.env.SSR ? Fragment : CheckCache | ||
| return ( | ||
| <Provider store={store}> | ||
| <CheckCacheComponent> | ||
| <Router staticUrl={staticUrl} origin={origin} routerContext={routerContext} routes={routes}/> | ||
| </CheckCacheComponent> | ||
| </Provider> | ||
| ) | ||
| } catch(error) { | ||
| // TODO log to sentry | ||
| console.error('[e][%s] render', process.env.SSR ? 'SSR' : 'SPA ⬇️') | ||
| console.error(error) | ||
| return ( | ||
| <Fragment> | ||
| {process.env.SSR && ( | ||
| <h2>500</h2> | ||
| )} | ||
| <p>Something went wrong.</p> | ||
| <p>Please try to reload the page or go to <a href="/">home</a></p> | ||
| </Fragment> | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| export default process.env.SSR ? App : require('react-hot-loader/root').hot(App) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to make SPA=true and SSR=?