Add fix to queries #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaMazur
force-pushed
the
queries_fix
branch
from
106ead7
to
a644175
Compare
alexgul4enko
suggested changes
Feb 20, 2020
| @@ -97,7 +97,7 @@ function getMetaFromResource(resource) { | |||
| } | |||
| return { | |||
| reducer: 'object', | |||
| ...resource, | |||
| ...omit(resource, 'queries'), | |||
There was a problem hiding this comment.
can u please explain why should it omit something? in resource u have data from api. It should not be omited
| @@ -177,7 +177,7 @@ export function makeResourceActions(resource, dispatch) { | |||
| const meta = getMetaFromResource(resource) | |||
| const actions = { | |||
| create: makeRequestAction('POST', meta, dispatch), | |||
| fetch: makeRequestAction('GET', meta, dispatch), | |||
| fetch: makeRequestAction('GET', { ...meta, queries: resource.queries }, dispatch), | |||
NikitaMazur
force-pushed
the
queries_fix
branch
3 times, most recently
from
8a97f3d
to
137191b
Compare
added 2 commits
February 26, 2020 16:00
NikitaMazur
force-pushed
the
queries_fix
branch
from
137191b
to
afe9dcf
Compare
alexgul4enko
approved these changes
Feb 26, 2020
NikitaMazur
force-pushed
the
queries_fix
branch
from
a35559b
to
804a4cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.