Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading of codecov reports #530

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Dec 7, 2018

Additionally requires uploading of coverage reports so such errors will be caught earlier on.

@sliverc sliverc changed the title WIP: Enforce successful upload of coverage files codecov Fix uploading of codecov reports Dec 7, 2018
@sliverc sliverc requested a review from n2ygk December 7, 2018 13:02
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@fd77738). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #530   +/-   ##
=========================================
  Coverage          ?   94.31%           
=========================================
  Files             ?       60           
  Lines             ?     3713           
  Branches          ?        0           
=========================================
  Hits              ?     3502           
  Misses            ?      211           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd77738...6a123df. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@n2ygk n2ygk merged commit f309c7c into django-json-api:master Dec 7, 2018
@sliverc sliverc deleted the fix_codecov branch December 7, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants