Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drf example fixtures #462

Merged
merged 4 commits into from
Aug 21, 2018
Merged

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Aug 21, 2018

Description of the Change

I've always been uncomfortable with the drf_example sqlite3 db binary file:

drf_example: SQLite 3.x database, last written using SQLite version 3019003

which includes a few rows of sample data.

This PR replaces it with a fixture. This adds one step to getting-started but makes it much more clear what the sample data is (and easier to maintain) .

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added (no new code)
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@n2ygk n2ygk requested a review from sliverc August 21, 2018 14:32
Copy link
Collaborator

@mblayman mblayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend using a JSON fixture instead of YAML to avoid the extra dependency on PyYAML for the example app. Otherwise, LGTM. 👍

@n2ygk n2ygk removed the request for review from sliverc August 21, 2018 19:18
@codecov-io
Copy link

codecov-io commented Aug 21, 2018

Codecov Report

Merging #462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files          54       54           
  Lines        3123     3123           
=======================================
  Hits         2912     2912           
  Misses        211      211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8821b99...2c6de09. Read the comment docs.

@n2ygk n2ygk merged commit 95e6d8d into django-json-api:master Aug 21, 2018
@n2ygk n2ygk deleted the drf_example_fixtures branch August 21, 2018 19:48
@n2ygk n2ygk added this to the 2.6.0 milestone Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants