-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New React front end #241
base: master
Are you sure you want to change the base?
New React front end #241
Conversation
Pull Request Test Coverage Report for Build 9178299879Details
💛 - Coveralls |
Add pre-commit config and fix all the things
@jochenklar I've encountered a strange bug in the schemas dropdown. In short, sometimes clicks on the columns change the active schema and table which is unexpected. Specifically, it jumps to a user table if a column with the same name as the clicked column exists there. The clicked column should not have an effect on the listed schemas and tables.
In particular, I don't really understand the reason for the following piece of code daiquiri/daiquiri/metadata/assets/js/components/Schemas.js Lines 66 to 71 in 7cb39a6
Are you searching for schemas and tables that contain the clicked column? why? I'm trying to fix it myself, so I just need a few pointers to understand the reasoning for the current implementation better :-). |
The bug seems to be fixed if the 'column' branch of the 'if-else' remains empty. } else if (activeItem.type == 'column') { } As of now, I don't see that anything else got broken because of this fix. |
This PR implements a new React front end, replacing AngularJS.