Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New React front end #241

Draft
wants to merge 158 commits into
base: master
Choose a base branch
from
Draft

New React front end #241

wants to merge 158 commits into from

Conversation

jochenklar
Copy link
Member

This PR implements a new React front end, replacing AngularJS.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9178299879

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 64.052%

Totals Coverage Status
Change from base Build 8016830665: 0.07%
Covered Lines: 4834
Relevant Lines: 7547

💛 - Coveralls

@kimakan
Copy link
Contributor

kimakan commented Jan 17, 2025

@jochenklar I've encountered a strange bug in the schemas dropdown. In short, sometimes clicks on the columns change the active schema and table which is unexpected. Specifically, it jumps to a user table if a column with the same name as the clicked column exists there. The clicked column should not have an effect on the listed schemas and tables.
afaik, the issue comes from the function updateBrowser

const updateBrowser = () => {

In particular, I don't really understand the reason for the following piece of code

} else if (activeItem.type == 'column') {
// search for the schema and the table for the column
const [schema, table] = schemas.reduce((result, schema) => {
const table = (schema.tables || []).find(t => (t.columns && t.columns.find(c => isEqual(c, activeItem))))
return isNil(table) ? result : [schema, table]
}, [])

Are you searching for schemas and tables that contain the clicked column? why?

I'm trying to fix it myself, so I just need a few pointers to understand the reasoning for the current implementation better :-).

@kimakan
Copy link
Contributor

kimakan commented Jan 21, 2025

The bug seems to be fixed if the 'column' branch of the 'if-else' remains empty.

} else if (activeItem.type == 'column') { }

As of now, I don't see that anything else got broken because of this fix.

@jochenklar
Copy link
Member Author

Hi @kimakan , I answer in #254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants