-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add licences of vendor icon libraries #167
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4245adc
Fix: Update locales and add floating options for images
fsbraun e66e618
Merge branch 'master' of github.com:fsbraun/djangocms-frontend
fsbraun cbaccdd
Merge branch 'master' of github.com:fsbraun/djangocms-frontend
fsbraun 66e053e
fix: icons not showing in ckeditor
fsbraun fec0ece
Merge branch 'django-cms:master' into master
fsbraun 49e4acc
Merge branch 'django-cms:master' into master
fsbraun a9ead97
Add image drag and drop
fsbraun 9ac7126
Merge branch 'master' of github.com:fsbraun/djangocms-frontend
fsbraun f5f27b6
Update docs
fsbraun 6d5fac4
Add tests
fsbraun 18d60ab
Fix tests for v4
fsbraun 44d5035
Bump version
fsbraun 210cccd
Update changelog
fsbraun 510494e
Merge branch 'django-cms:master' into master
fsbraun 68e9776
Add icon vendor licences, remove icomoon and happy icons due to uncle…
fsbraun ac9b2d9
Add elegant icons upstream url
fsbraun 71dc48a
Removed zondicons due to unclear licence, added all upstream links an…
fsbraun c73572f
Fix typo
fsbraun a8a20ab
Remove zondicons from config
fsbraun e01d9a3
Correct open iconic licence
fsbraun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3,269 changes: 0 additions & 3,269 deletions
3,269
...contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/happy-icons.svg
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-125 KB
...frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/happy-icons.woff
Binary file not shown.
Binary file removed
BIN
-101 KB
...rontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/happy-icons.woff2
Binary file not shown.
Binary file removed
BIN
-103 KB
...ocms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/icomoon.eot
Binary file not shown.
501 changes: 0 additions & 501 deletions
501
...end/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/icomoon.svg
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-103 KB
...ocms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/icomoon.ttf
Binary file not shown.
Binary file removed
BIN
-103 KB
...cms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/icomoon.woff
Binary file not shown.
Binary file removed
BIN
-44.7 KB
...cms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/zondicon.eot
Binary file not shown.
307 changes: 0 additions & 307 deletions
307
...nd/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/zondicon.svg
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-44.6 KB
...cms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/zondicon.ttf
Binary file not shown.
Binary file removed
BIN
-44.7 KB
...ms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts/zondicon.woff
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hearing rumours that there is still something trying to load these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any indications? They're still in the docs though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I picked up this issue: django-cms/django-cms-quickstart#58 and traced the error back to this PR. Downgrading to
1.2.0
seems to resolve the bug. I have not gone deep into this yet, but I can still grep for files with the same name as those icon libraries:/djangocms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/icons-libraries/icomoon.json
(not sure if that's relevant at the moment).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be related to my findings in #166 (comment) from about a month ago, id est that some files still reference the old icon sets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefan6419846 It is! Thank you! The css files reference the removed fonts which breaks whitenoise. I have removed the css files a month ago. This needs to go through the release process now!
The json files are staying, so that people fine with the iconset's license can use them more easily.