Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in v3.10 #171

Closed
ljharb opened this issue Aug 19, 2021 · 1 comment
Closed

Breaking change in v3.10 #171

ljharb opened this issue Aug 19, 2021 · 1 comment

Comments

@ljharb
Copy link

ljharb commented Aug 19, 2021

Upgrading json5 from v1 to v2 is a breaking change, because json5 v2 does not work in node 4, and tsconfig-paths v3.9 does.

Please revert to json5 v1, so eslint-plugin-import can continue to use the latest version of this package.
@ljharb ljharb mentioned this issue Aug 19, 2021
Merged
ljharb added a commit to import-js/eslint-plugin-import that referenced this issue Aug 19, 2021
@ljharb
[Deps] pin tsconfig-paths due to a breaking change in v3.10
6c957e7 
See dividab/tsconfig-paths#171
@jonaskello jonaskello mentioned this issue Aug 24, 2021
Merged
ljharb added a commit to ljharb/eslint-plugin-import that referenced this issue Aug 24, 2021
@ljharb
[Deps] unpin tsconfig-paths
51d3973 
dividab/tsconfig-paths#171 fixed in dividab/tsconfig-paths#173
@ljharb
Copy link
Author

ljharb commented Aug 24, 2021

Confirmed fixed in #173 / v3.11

@ljharb ljharb closed this as completed Aug 24, 2021
@F3n67u F3n67u mentioned this issue Apr 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ljharb