Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell executor crashing on missing command #948

Merged
merged 1 commit into from
May 6, 2021
Merged

Fix shell executor crashing on missing command #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions builtin/bins/dkron-executor-shell/shell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ func buildCmd(command string, useShell bool, env []string, cwd string) (cmd *exe
if err != nil {
return nil, err
}
if len(args) == 0 {
return nil, errors.New("shell: Command missing")
}
cmd = exec.Command(args[0], args[1:]...)
}
if env != nil {
Expand Down
4 changes: 4 additions & 0 deletions builtin/bins/dkron-executor-shell/shell_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import (
"github.com/stretchr/testify/assert"
)

func Test_buildCmdInvalidInput(t *testing.T) {
assert.NotPanics(t, func() { buildCmd("", false, []string{}, "") })
}

func Test_buildCmd(t *testing.T) {

// test shell command
Expand Down