-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some query filters on Job executions #878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but could you rename JobExecutionsOptions
to ExecutionOptions
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work unless executions are stored in json in BuntDB, now they are stored in binary protobuf, or am I missing something?
Yes, the executions are stored in binary Protobuf with |
Done! |
Then why implement this if it does not work? You can implement json marshal/unmarshal with fallback to proto.Unmarshal as I did with jobs, take a look at https://github.com/distribworks/dkron/blob/master/dkron/store.go#L309-L315
You mean ASC or DESC by the key? |
Indeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.