-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Action for release (binary and docker) #770
Conversation
@Victorcoder and no <3 for this one too ^^ ? |
out of curiosity @Victorcoder , what leaves you uneasy on this PR? it's the simple change to GA that we discussed in gitter :) |
Sorry for the delay @fopina didn't have time to look into it until now |
This works fine in rusberry pi 4 (ubuntu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the comment it LGTM, thanks!
--platform linux/amd64,linux/arm64,linux/arm/v7 \ | ||
--build-arg VERSION=${{ steps.prepare.outputs.tag_name }} \ | ||
--push \ | ||
-t ${DOCKER_REPO:-dkron/dkron}:${{ steps.prepare.outputs.tag_name }} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the Major version tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging this, I will add the tag
Sorry, away from computer these days. Cool! |
buildkit
-> allows for multi-arch builds -> GoReleaser has had this open 2 years Support multi-platform docker images goreleaser/goreleaser#530 and it's still about the previous way (building each image and bundling thedocker manifest
), buildkit does it all in one goscripts/release
no longer required, but left in case you want to do some manual releaseLeft a few "fork friendly" items in workflow that won't affect dkron/dkron and make it easy to release patched versions from forks :D but we remove of course, if you prefer.