Refactor Run #749
Merged
Refactor Run #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serf queries works over UDP sending messages to nodes and expecting a response, there is no guarantee or verification of the message delivery. This was causing some job executions to be lost, around 1%-2% on edge cases. Solution Agents will listen to gRPC calls from the servers, using server-side streaming, the other way around as currently, agents will send Execution progress as now. Servers will actively order nodes to run the jobs, so we can verify the job is actually being executed or report an error in case it's not. This maintains the same guarantees in job status reporting and streaming, also adding the possibility to cancel an execution in the future.
This was referenced May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Serf queries works over UDP sending messages to nodes and expecting a response, there is no guarantee or verification of the message delivery. This was causing some job executions to be lost, around 1%-2% on edge cases.
Solution
Agents will listen to gRPC calls from the servers, using server-side streaming, the other way around as currently, agents will send Execution progress as now.
Servers will actively order nodes to run the jobs, so we can verify the job is actually being executed or report an error in case it's not.
This maintains the same guarantees in job status reporting and streaming, also adding the possibility to cancel an execution in the future.
Fixes #731 #744