Add job name tags to log events to improve debugging #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the log calls had the job_name tag, but others did not. This adds them to those calls that were missing to improve log correlation, especially when there are many jobs all with the same schedule (i.e. @every 1m) and these execution log entries are all intertwined.
vcastellm
requested changes
Apr 27, 2020
|
Quite happy to convert while I'm already making changes. All occurrences now use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the log calls had the job_name tag, but others did not. This adds them to those calls that were missing to improve log correlation, especially when there are many jobs all with the same schedule (i.e. @every 1m) and these execution log entries are all intertwined.
I kept the "job_name" key to match other logging calls in this file, but it seems to be inconsistent with other files (store.go uses "job")