Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuntDB with delete executions and fixed tests #702

Merged
merged 4 commits into from
Mar 12, 2020
Merged

BuntDB with delete executions and fixed tests #702

merged 4 commits into from
Mar 12, 2020

Conversation

andreygolev
Copy link
Contributor

This is a PR based on buntdb branch.
Differences:

  • Added deleting of executions in DeleteJob method.
  • Added ignore self in listing in listTxFunc. (wasn't in buntdb branch)
  • Fixed check for metadata in job in DeleteJob method. (tests were failing)
  • Some renames
  • BadgerDB fully removed
  • Snapshot and Restore methods in Store returning nil. Looks like these are required for Raft, but we don't need to snapshot or restore BuntDB as it's restored via Raft.

vcastellm
vcastellm requested changes Mar 11, 2020
View reviewed changes
dkron/store.go Outdated
type Store struct {
db *badger.DB
agent *Agent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this as it's not used

vcastellm
vcastellm requested changes Mar 11, 2020
View reviewed changes
dkron/store.go Show resolved Hide resolved
dkron/store.go Show resolved Hide resolved
dkron/store.go Show resolved Hide resolved
@andreygolev andreygolev requested a review from vcastellm March 12, 2020 09:27
vcastellm
vcastellm requested changes Mar 12, 2020
View reviewed changes
dkron/store.go Outdated Show resolved Hide resolved
@andreygolev andreygolev requested a review from vcastellm March 12, 2020 12:05
vcastellm
vcastellm approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work!

@vcastellm vcastellm merged commit 858cbf6 into distribworks:master Mar 12, 2020
@vcastellm vcastellm mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreygolev @vcastellm