Graceful shutdown #690
Merged
Graceful shutdown #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to finish before dying.
vcastellm
reviewed
Mar 5, 2020
| log.Info("agent: Gracefully shutting down agent...") | ||
| go func() { | ||
| plugin.CleanupClients() |
There was a problem hiding this comment.
I've tested it only with containers. Container exits, and the everything that was running inside dies also. So it doesn't matter in my case :)
But you're right, not everyone is using containers.
I'll add plugin.CleanupClients() somewhere below
vcastellm
reviewed
Mar 6, 2020
cmd/agent.go
Outdated
| time.Sleep(1 * time.Second) | ||
| } | ||
|
|
||
| plugin.CleanupClients() |
There was a problem hiding this comment.
Sorry, edited it with vi first :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I started to test graceful shutdown of worker type agents, it appeared that they don't wait for their running jobs before shutdown.
If I recall correctly, plugin.CleanupClients() kill plugins immediately, causing childs (in case of shell executor) to die.
This PR does the following:
Note: Running jobs successfully can send ExecutionDone to leader even after agent left cluster.