Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash when plugin configuration is not defined in a job #689

Merged

Conversation

andreygolev
Copy link
Contributor

If there's no plugin configuration in a job definition, dkron will crash with error:
panic: assignment to entry in nil map

This PR fixes it.

Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcastellm
Copy link
Member

I don't know why this test is failing

@vcastellm
Copy link
Member

@andreygolev can you modify .github actions to this?

name: Test
on: [push,pull_request]
jobs:
  build:
    name: Test
    runs-on: ubuntu-latest
    steps:

    - name: Set up Go 1.14
      uses: actions/setup-go@v1
      with:
        go-version: 1.14
      id: go

    - name: Check out code into the Go module directory
      uses: actions/checkout@v2

    - name: Get dependencies
      run: go get -v -t -d ./...

    - name: Test without docker
      run: go test -v -timeout 200s ./...

@vcastellm vcastellm merged commit 1eb623c into distribworks:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants