Fix race condition in job update #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported #299 This fixes a race condition with the job update after execution. In this PR the lock is refactored to an Atomic job put, that reads the job, updates it and performs a CAS operation to update it in the store. If this update fails, it retryies it until it's updated. This ensures no race condition between nodes and efectively fixes the reported error.
Closed
|
Thanks！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported #299
This fixes a race condition with the job update after execution.
In this PR the lock is refactored to an Atomic job put, that reads the job, updates it and performs a CAS operation to update it in the store.
If this update fails, it retryies it until it's updated.
This ensures no race condition between nodes and efectively fixes the reported error.
Fixes #299