Minor improvement in RabbitMQ executor #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-kripakov-m10
force-pushed
the
rabbit_mq_plugin_updates
branch
from
ee97ccf to
8ce2e10
Compare
ivan-kripakov-m10
force-pushed
the
rabbit_mq_plugin_updates
branch
from
8ce2e10 to
f50de71
Compare
ivan-kripakov-m10
force-pushed
the
rabbit_mq_plugin_updates
branch
from
5c8a9c0 to
38efd8a
Compare
ivan-kripakov-m10
changed the title
vcastellm
reviewed
Mar 31, 2024
| } | ||
|
|
||
| func createQueueIfNecessary(cfg map[string]string, queue string, ch *amqp.Channel) error { | ||
| if val, ok := cfg["queue.create"]; !ok || (ok && val == "false") { |
There was a problem hiding this comment.
Should this query rabbit in order to check if the queue already exists?
There was a problem hiding this comment.
I think we don't need to check if the queue exists here. If the user chooses not to create the queue via the plugin, we expect him to create it manually.
If the user doesn't declare the queue, message publishing will fail with error in logs or a failed execution in UI.
vcastellm
added a commit
that referenced
this pull request
Oct 6, 2024
* Convert shell plugin to internal plugin (#975) The purpose of this PR is to embed the shell plugin in the main dkron binary, that will facilitate creating a single binary with the most important executor, for easy deployment using a single binary. * Remove old UI (#984) * Release a light image tag (#988) Omit all plugins except the shell plugin that will be included in the main binary. * Upgrade react admin to v4 (#1436) * Use exponential backoff for retries (#1433) * Handle ip changes (#1446) * consul like approach: add server_lookup to make dkron independent from server node IP on raft layer * handle memberupdate event * query other servers before start & add test * don't remove itself if node is a raft leader * don't remove dkron server node if id matches * Move config init to agent command (#1465) Config init was being done on the root level command but only the agent command was using config values. Now config init is done as pre-run of agent command only, getting rid of extra messages in other commands when the config was missing. * Fix disabled (#1467) * Embed http plugin (#1471) http plugin is one of the most used plugins together with the shell plugin, embedding it in the main binary allow for more lean deployment. * Show all Job fields * Refactor buttons for admin v4 * Docs v4 (#1473) * Reuse http clients with the same configuration (#1474) * Update OpenAPI spec to v3.1.0 and add ACLs spec * Refactor location of types as they not only belong to plugins, but used in general. (#1485) Also add Pro protobuf and gen code as this should be public. * Generate client * Extend protobuf defs for ACLs * Token fields * Minor improvement in RabbitMQ executor (#1500) * nice and forkable goreleaser (#1584) * add support for hash scheduling (#1260) * feat: Login form and admin update (#1589) Upgrade react-admin to v5 Implements a login form to use in Pro version --------- Co-authored-by: Victor Castell <[email protected]> Co-authored-by: Ivan Kripakov <[email protected]> Co-authored-by: Filipe Pina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide possibility to decide whether to create queues when using RabbitMQ executor and possibility to choose queue's configuration (
durable,auto_delete,exclusive) if user decides to create the queue via plugin.Also allows users to customize message publishing using
messageId,contentTypeanddelivery_modeoptions.