Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic if get job from store failed #289

Closed
johnnyjian opened this issue Jul 19, 2017 · 2 comments
Closed

Panic if get job from store failed #289

johnnyjian opened this issue Jul 19, 2017 · 2 comments

Comments

@johnnyjian
Copy link

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xa0 pc=0x9ccfb2]

goroutine 72934 [running]:
github.com/victorcoder/dkron/dkron.(*AgentCommand).processFilteredNodes(0xc4201b67e0, 0x0, 0xef9180, 0xc4200156a0, 0xef9100, 0xc42018ff00, 0xc420281220, 0x403b2d)
/Users/victorcoder/src/github.com/victorcoder/dkron/dkron/agent.go:590 +0x72
github.com/victorcoder/dkron/dkron.(*AgentCommand).RunQuery(0xc4201b67e0, 0xc42009a000)
/Users/victorcoder/src/github.com/victorcoder/dkron/dkron/queries.go:39 +0xe9
github.com/victorcoder/dkron/dkron.(*Job).Run(0xc420130fc0)
/Users/victorcoder/src/github.com/victorcoder/dkron/dkron/job.go:110 +0x344
created by github.com/victorcoder/dkron/cron.(*Cron).run
/Users/victorcoder/src/github.com/victorcoder/dkron/cron/cron.go:159 +0x451

It is caused by ignoring error returning by a.store.GetJob in AgentCommand.RunQuery.

@vcastellm
Copy link
Member

Why GetJob is not working in this case?

@johnnyjian
Copy link
Author

because the store is temporarily down.

vcastellm pushed a commit that referenced this issue Oct 17, 2017
Fix #289. Handle getting job error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants