New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPC Executor dosn`t close connection after exec #1236

Closed

edwsel opened this issue Dec 9, 2022 · 0 comments

Contributor

edwsel commented Dec 9, 2022

Describe the bug
GRPC Executor doesn t close connection after exec

To Reproduce
Steps to reproduce the behavior:

Create grpc job executor with schedule 1s
Wait some time for enough tasks completed
Make command netstat -nep | grep ESTABLISHED| wc -l in cli on container (docker), we get many open connection

Expected behavior
After job exec connection over grpc must be closed

Additional context
I have think about problem in after error check https://github.com/distribworks/dkron/blob/master/builtin/bins/dkron-executor-grpc/grpc.go#L94
This line doesn t have defer cc.Close()

The text was updated successfully, but these errors were encountered:

edwsel pushed a commit to edwsel/dkron that referenced this issue


          fixed distribworks#1236 isuse in main repo

281eefa

edwsel pushed a commit to edwsel/dkron that referenced this issue


          distribworks#1236 fixed for PR

c4b2dcb

vcastellm closed this as completed in

ad0c608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment