Merge pull request #679 from distribworks/fix_671

fix: Return the correct status code on leader endpoint
distribworks · Feb 12, 2020 · ea0ea8b · ea0ea8b
2 parents 7da930c + a628c39
commit ea0ea8b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/dkron/api.go b/dkron/api.go
@@ -240,9 +240,13 @@ func (h *HTTPTransport) membersHandler(c *gin.Context) {
 
 func (h *HTTPTransport) leaderHandler(c *gin.Context) {
 	member, err := h.agent.leaderMember()
-	if err == nil {
-		renderJSON(c, http.StatusOK, member)
+	if err != nil {
+		c.AbortWithError(http.StatusInternalServerError, err)
+	}
+	if member == nil {
+		c.AbortWithStatus(http.StatusNotFound)
 	}
+	renderJSON(c, http.StatusOK, member)
 }
 
 func (h *HTTPTransport) leaveHandler(c *gin.Context) {