Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please update github.com/Azure/azure-sdk-for-go vendoring #2496

Closed
nim-nim opened this issue Jan 14, 2018 · 3 comments
Closed

please update github.com/Azure/azure-sdk-for-go vendoring #2496

nim-nim opened this issue Jan 14, 2018 · 3 comments
Labels
area/storage/azure priority/P0 Must have. Very high priority item.

Comments

@nim-nim
Copy link

nim-nim commented Jan 14, 2018

The vendored github.com/Azure/azure-sdk-for-go version is obsolete and relies on code of dubious legal status (the godo bits). Please update to a current release which has not got this problem anymore.

@dmcgowan
Copy link
Collaborator

ping @yuwaMSFT2

@yuwaMSFT2
Copy link
Contributor

I will prepare a PR for this

@elboulangero
Copy link

Any news on that?

I'm attempting to package docker-distribution for Debian, and hence to build it against the Go libraries shipped by Debian (no vendoring). And right now in Debian unstable, we have azure-sdk v10.

When I try to build against v10 I get these errors.

# github.com/docker/distribution/registry/storage/driver/azure
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:90:44: not enough arguments in call to containerRef.CreateIfNotExists
	have ()
	want (*storage.CreateContainerOptions)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:107:23: d.client.GetBlob undefined (type storage.BlobStorageClient has no field or method GetBlob)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:136:24: d.client.GetBlobProperties undefined (type storage.BlobStorageClient has no field or method GetBlobProperties)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:141:21: d.client.DeleteBlob undefined (type storage.BlobStorageClient has no field or method DeleteBlob)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:147:17: d.client.CreateBlockBlobFromReader undefined (type storage.BlobStorageClient has no field or method CreateBlockBlobFromReader)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:153:24: d.client.BlobExists undefined (type storage.BlobStorageClient has no field or method BlobExists)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:159:23: d.client.GetBlobProperties undefined (type storage.BlobStorageClient has no field or method GetBlobProperties)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:170:23: d.client.GetBlobRange undefined (type storage.BlobStorageClient has no field or method GetBlobRange)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:180:29: d.client.BlobExists undefined (type storage.BlobStorageClient has no field or method BlobExists)
src/github.com/docker/distribution/registry/storage/driver/azure/azure.go:187:35: d.client.GetBlobProperties undefined (type storage.BlobStorageClient has no field or method GetBlobProperties)

yuwaMSFT2 added a commit to yuwaMSFT2/distribution that referenced this issue May 21, 2018
Update Azure SDK with release v16.2.1
Update Azure autorest SDK with release v10.8.1

Signed-off-by: Yu Wang <[email protected]>
yuwaMSFT2 added a commit to yuwaMSFT2/distribution that referenced this issue May 21, 2018
Update Azure SDK with release v16.2.1
Update Azure autorest SDK with release v10.8.1

Signed-off-by: Yu Wang <[email protected]>
yuwaMSFT2 added a commit to yuwaMSFT2/distribution that referenced this issue May 21, 2018
Update Azure SDK with release v16.2.1
Update Azure autorest SDK with release v10.8.1

Signed-off-by: Yu Wang <[email protected]>
yuwaMSFT2 added a commit to yuwaMSFT2/distribution that referenced this issue May 21, 2018
Update Azure SDK with release v16.2.1
Update Azure autorest SDK with release v10.8.1

Signed-off-by: Yu Wang <[email protected]>
@dmp42 dmp42 added priority/P0 Must have. Very high priority item. area/storage/azure labels May 26, 2018
dmcgowan added a commit that referenced this issue Jun 11, 2018
cquon pushed a commit to cquon/distribution that referenced this issue Aug 31, 2018
Update Azure SDK with release v16.2.1
Update Azure autorest SDK with release v10.8.1

Signed-off-by: Yu Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage/azure priority/P0 Must have. Very high priority item.
Projects
None yet
Development

No branches or pull requests

5 participants