Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There were several problems with the systemtap script in pbench: #5

Closed
wants to merge 1 commit into from
Closed

There were several problems with the systemtap script in pbench: #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions agent/tool-scripts/systemtap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,8 @@ pbench_bin="`cd ${script_path}/..; /bin/pwd`"
# Defaults
tool=$script_name
tool_bin=staprun
ver=10.2.1
tool_url="http://pagesperso-orange.fr/sebastien.godard/sysstat-$ver.tar.bz2"
group=default
dir="/tmp"
mode=""
interval="10"
iteration="1"
options="none"

# Process options and arguments
opts=$(getopt -q -o idp --longoptions "dir:,script:,group:,iteration:,options:,start,stop,install,postprocess" -n "getopt.sh" -- "$@");
Expand Down Expand Up @@ -86,9 +80,10 @@ while true; do
--script)
shift;
if [ -n "$1" ]; then
script="$1"
script=`echo $1 | sed 's/^"\(.*\)"$/\1/'`
shift
echo script is $script
else
echo "you did not provide a script"
fi
;;
-o|--options)
Expand All @@ -115,6 +110,9 @@ case "$mode" in
install)
# the installation for systemtap includes compiling the kernel module from the stap script
# this is done to avoid extra overhead when the workload is running
check_install_rpm systemtap-client
check_install_rpm systemtap-devel
check_install_rpm kernel-devel
pushd $pbench_tmp >/dev/null
install_cmd="stap -v -m pbench_systemtap -p4 $script"
printf "%s\n" $script
Expand All @@ -123,6 +121,7 @@ case "$mode" in
popd >/dev/null
;;
start)
mkdir -p $tool_output_dir
if [ -e $tool_output_file ]; then
/bin/rm $tool_output_file
fi
Expand Down