register-tool includes tool options w tool script #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's important that register-tool include the tool options when making the call to the tool-specific script. Sometimes installing that tool requires those options, like with systemtap.
|
Replaces #4. |
portante
added a commit
that referenced
this pull request
Jul 31, 2015
register-tool includes tool options w tool script
portante
pushed a commit
to portante/pbench
that referenced
this pull request
Jul 31, 2015
There were several problems with the systemtap script in pbench:
1) unused variables (script was probably copied from sar)
2) the $script var must have the leading and trailing quotes
removed. We embed these quotes for tool options in register-tool
and start-tools to avoid white-space issues, but for some reason
the stap command does not like dealing with quotes in its
arguments (all other tools seem unaffected).
3) No required packages were installed (like systemtap!)
4) The directory where systemtap output is collected was not
created.
Note that while this changeset should apply cleanly without two other
pull requests:
distributed-system-analysis#41
distributed-system-analysis#42
This changeset does require those 2 to function properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important that register-tool include the tool options when making
the call to the tool-specific script. Sometimes installing that tool
requires those options, like with systemtap.