-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nits and stuff #3514
Nits and stuff #3514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a shell linter? And you're running it? Weird. 🍤
Yeah, there is. Yeah, I am. And, yeah, it makes life "interesting". I don't necessarily agree with everything it says, but there are enough pitfalls in shell programming that I do appreciate having the heads-up when I'm doing something questionable (or when there is a better/alternate way to do it that I wasn't aware of). |
This PR consists of a bunch of tiny fixes of minimal consequence which I've gradually accumulated over the last month. They were things which I ran into in the course of making other changes, but, since they had nothing to do with the changes I was making, I kept them on a side branch. At this point, there are enough of them to warrant putting up a review.
load_keycloak.sh
urllib3
package and add a requirement for it: the package is apparently included inside therequests
package, and we were referencing it there instead of declaring our own dependency on it.deploy-dependencies
script: this script is normally invoked by a higher-level script which provides these definitions; if a user wants to run this script independently, then s/he has to "just know" to provide these definitions in the environment; this change provides reasonable default values if the variables are not already defined.exec
call inside the script which is run as the container entrypoint will fail, and this results in a cryptic response (if any) for the user. This PR modifies the entry point script script to try to handle these cases better for the user.