Identify benchmark type #3495
Merged
Identify benchmark type #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBENCH-1210 Right now we only support visualizing and comparing `uperf` benchmark data with Quisby. However as we expand that support within the server, the UI code will need to be able to identify the schema of the output data, which depends on the benchmark. As a simple solution, add a `"benchmark"` field to the response data which the client can read.
dbutenhof
added
Server
API
siddardh-ra
approved these changes
Jul 12, 2023
ndokos
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1210
Right now we only support visualizing and comparing
uperfbenchmark data with Quisby. However as we expand that support within the server, the UI code will need to be able to identify the schema of the output data, which depends on the benchmark.As a simple solution, add a
"benchmark"field to the response data which the client can read.