crontab exorcism #3483
Merged
crontab exorcism #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBENCH-1206 When use of crontab was removed in favor of a timed systemd service, some loose ends were overlooked. Also, the BindsTo directive was put in the wrong section of the timer service file, leading to (apparently innocuous) warnings on startup. This does some cleanup.
ndokos
approved these changes
Jul 7, 2023
webbnh
approved these changes
Jul 7, 2023
Comment on lines
-71
to
-73
| # Default roles this pbench server takes on, see crontab roles below. | ||
| roles = pbench-results | ||
|
|
There was a problem hiding this comment.
Ditto for server/pbenchinacan/etc/pbench-server/pbench-server.cfg?
There was a problem hiding this comment.
No: we only define the crontab roles in the default config file. We don't duplicate that in pbench-server.cfg.
There was a problem hiding this comment.
It looks like it's doing the backstroke ... but it's in the wrong pond. 😦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1206
When use of crontab was removed in favor of a timed systemd service, some loose ends were overlooked. Also, the BindsTo directive was put in the wrong section of the timer service file, leading to (apparently innocuous) warnings on startup. This does some cleanup.