Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSSL to container build #3467

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

dbutenhof
Copy link
Member

PBENCH-1188

Running now on an up-to-date Fedora 38 laptop, I'm finally able to use jenkins/runlocal without overriding the BASE_IMAGE... except that I had to manually install the openssl package on my laptop, and it apparently also needs to be manually installed inside the container base image.

PBENCH-1188

Running now on an up-to-date Fedora 38 laptop, I'm finally able to use
`jenkins/runlocal` without overriding the `BASE_IMAGE`... except that I
had to manually install the `openssl` package on my laptop, and it
apparently also needs to be manually installed inside the container
base image.
@dbutenhof dbutenhof added Server packaging Issues related to software packaging Tests labels Jun 16, 2023
@dbutenhof dbutenhof requested review from webbnh, npalaska and riya-17 June 16, 2023 14:33
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is only necessary because you're using an "unexpected" base image. (I.e., we expect to build the Pbench Server container based on a UBI image (gonna be ubi8 "real soon now"...), but it shouldn't hurt to try to install openssl (i.e., on UBI that package should already be present...).)

(We really need to get runlocal to build the RPM using the appropriate distro instead of building it on the local host, and then we could break this requirement to build the Pbench Server container with a distro which matches the local host, and then maybe we could climb out of this matrix problem that we're in.)

@dbutenhof
Copy link
Member Author

I think this is only necessary because you're using an "unexpected" base image. (I.e., we expect to build the Pbench Server container based on a UBI image (gonna be ubi8 "real soon now"...)

Well, the script doesn't see it that way, because the base image is selected based on the host, and for Fedora it selects fedora:38. So at least for now, this seemed like the simplest solution.

@dbutenhof dbutenhof merged commit fb64f6f into distributed-system-analysis:main Jun 16, 2023
@dbutenhof dbutenhof deleted the cssl branch June 16, 2023 19:42
@webbnh
Copy link
Member

webbnh commented Jun 16, 2023

Well, the script doesn't see it that way, because the base image is selected based on the host, and for Fedora it selects fedora:38.

True enough. And, if I get some spare cycles, I'm going to see about changing the script's perspective. 😁

at least for now, this seemed like the simplest solution.

Yep; and so I approved it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Issues related to software packaging Server Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants