Remove HTTP access to the canned Pbench Server #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
added
Agent
Documentation
Server
Code Infrastructure
Dashboard
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
webbnh
force-pushed
the
remove_HTTPS
branch
4 times, most recently
from
9bbd144 to
fe90ad1
Compare
webbnh
force-pushed
the
remove_HTTPS
branch
4 times, most recently
from
6274eea to
ab0e955
Compare
Access now requires HTTPS. Update the Ansible firewall playbooks, the Server documentation examples, the default Agent configuration, the run-server-func-tests script, the unit tests and unit test infrastructure, the canned Nginx proxy configuration, and the Keycloak redirect configuration and the Keycloak access adapter. PBENCH-1176
|
This PR is now ready for review (or will be, once it gets past Area-51). |
dbutenhof
previously approved these changes
Jun 22, 2023
agent/ansible/collection/roles/pbench_firewall_open_ports/README.md
Outdated
Show resolved
Hide resolved
dbutenhof
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have HTTPS access to the Pbench Server enabled and working, it's time to remove HTTP access.
This PR updates:
run-server-func-testsscriptOpenIDClientreplacing
http://*:8080withhttps://*:8443.Note that this PR does not change access to the Keycloak broker...which should be done as soon as practical once this change is merged.
PBENCH-1176