Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some API documentation fixes #3441

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

dbutenhof
Copy link
Member

PBENCH-819

This is primarily a minor "cleanup pass" to make some specific example paths more generic and retire a long-standing story.

Along the way I also found a few places I'd missed during the REST API changes so I fixed them as well. Finally, I added a relay.md API file for the new Relay API.

Any other bugs, omissions, or other comments in API documentation could also be considered "in scope" here.

@dbutenhof dbutenhof added Documentation Server API Of and relating to application programming interfaces to services and functions labels May 30, 2023
@dbutenhof dbutenhof self-assigned this May 30, 2023
webbnh
webbnh previously approved these changes May 30, 2023
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are some things below which you may want to consider.

docs/Server/API/README.md Outdated Show resolved Hide resolved
docs/Server/API/V1/README.md Outdated Show resolved Hide resolved
docs/Server/API/V1/contents.md Outdated Show resolved Hide resolved
docs/Server/API/V1/contents.md Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
docs/Server/API/V1/relay.md Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
dbutenhof added 2 commits May 31, 2023 12:24
PBENCH-819

This is primarily a minor "cleanup pass" to make some specific example paths
more generic and retire a long-standing story.

Along the way I also found a few places I'd missed during the REST API changes
so I fixed them as well. Finally, I added a `relay.md` API file for the new
Relay API.

Any other bugs, omissions, or other comments in API documentation could also
be considered "in scope" here.
webbnh
webbnh previously approved these changes May 31, 2023
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (I've got three small editorial suggestions, if you're interested; the others are our on-going discussions which don't have to bear on this PR.)

docs/Server/API/V1/README.md Outdated Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
docs/Server/API/V1/contents.md Outdated Show resolved Hide resolved
docs/Server/API/V1/contents.md Show resolved Hide resolved
docs/Server/API/V1/relay.md Outdated Show resolved Hide resolved
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

Copy link
Member

@siddardh-ra siddardh-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbutenhof dbutenhof merged commit 1dbad11 into distributed-system-analysis:main Jun 1, 2023
@dbutenhof dbutenhof deleted the apifix branch June 1, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Of and relating to application programming interfaces to services and functions Documentation Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants