Disable redis protected mode #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndokos
added
bug
Agent
Tool Meister
dbutenhof
approved these changes
May 24, 2023
Fixes distributed-system-analysis#3403. Fedora 37 and Fedora 38 run it in protected mode by default. We probably should be doing that everywhere but for the time being, we turn it off everywhere instead. PBENCH-1163
ndokos
force-pushed
the
redis-protected-mode-b0.72
branch
from
061dfc1 to
819c302
Compare
|
This was just an edit of the commit message of the first commit (mainly to add the ticket number). |
|
I don't think the tests are overriding the config: they are just reporting it. |
|
Is there a forward-port of this change for |
|
Maybe - but I was wondering whether it would be a good idea to enable protected mode everywhere, rather than disabling it. |
ndokos
added a commit
to ndokos/pbench
that referenced
this pull request
Jun 7, 2023
Fixes distributed-system-analysis#3403. Fedora 37 and Fedora 38 run it in protected mode by default. We probably should be doing that everywhere but for the time being, we turn it off everywhere instead. Fix the util-scripts tool-meister tests PBENCH-1163
ndokos
added a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3403
Fedora 37 and Fedora 38 run it in protected mode by default. We probably should be doing that everywhere but for the time being, we turn it off everywhere instead.
Smoke tested against all supported distros: everybody succeeds except RHEL 7 which currently fails for unrelated reasons.
PBENCH-1163